Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MNG-7883] Also print groupId and version in the Reactor Build Order #1511

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

chenchc6
Copy link

@chenchc6 chenchc6 commented May 17, 2024

JIRA Issue: MNG-7883

Description:
This pull request addresses the enhancement described in JIRA issue MNG-7883. The goal is to improve the readability and completeness of the Reactor Build Order output by including groupId and version information for each module. This change is necessary to provide developers with more detailed information about the modules being built, which can help in debugging and understanding the build process.

Changes Made:

  • Modified the ExecutionEventLogger class to include groupId and version information in the Reactor Build Order output.
  • Updated the sessionStarted method to format the output with the new information, ensuring clarity and consistency.

Implementation Details:

  • The sessionStarted method in ExecutionEventLogger was updated to construct a formatted string containing the groupId, artifactId, and version for each module.
  • Adjusted the spacing and alignment to ensure the output remains clear and readable.

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [MNG-XXX] SUMMARY,
    where you replace MNG-XXX and SUMMARY with the appropriate JIRA issue.
  • Also format the first line of the commit message like [MNG-XXX] SUMMARY.
    Best practice is to use the JIRA issue title in both the pull request title and in the first line of the commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the Core IT successfully.

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

Copy link
Contributor

@gnodet gnodet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants