Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MNG-8180] Fail install/deploy if rogue Maven Plugin metadata found #1612

Merged
merged 2 commits into from
Jul 11, 2024
Merged

[MNG-8180] Fail install/deploy if rogue Maven Plugin metadata found #1612

merged 2 commits into from
Jul 11, 2024

Commits on Jul 11, 2024

  1. [MNG-8180] Fail install/deploy if rogue Maven Plugin metadata found 

    Resolver handles transparently the repository metadata, and in case of plugins it peeks into META-INF/maven/plugin.xml of given artifact JAR to figure out needed metadata bits (prefix, name, etc).

But, this was done "blindly", while it is expected that GA of JAR artifact without classifier (requirement for maven plugins) and GA in embedded plugin metadata must be same.

Decision here is to fail hard, prevent this being installed and deployed, as this is most probably wrong (unsure what maven-indexer or even Sonatype search would do in this case).

---

https://issues.apache.org/jira/browse/MNG-8180
    @cstamas
    cstamas committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    9fa96f2 View commit details
    Browse the repository at this point in the history

  2. Complete the UT

    @cstamas
    cstamas committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    734cf47 View commit details
    Browse the repository at this point in the history