[MNG-8197] Use default classifier when Eclipse Aether specifies none #1621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The important change in this commit is in the implementation of `getClassifier()` methods. However, this commit opportunistically refactors the code with a base class shared by `DefaultDependency` and `DefaultDependencyCoordinate` implementations.
cstamas
approved these changes
Aug 1, 2024
…n wrapping the object from Maven model.
cstamas
changed the title
gnodet
approved these changes
Aug 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The important change in this commit is in the implementation of
getClassifier()methods. However, this commit opportunistically refactors the code with a base class shared byDefaultDependencyandDefaultDependencyCoordinateimplementations.Note on build failure
Trying to compile Maven with itself (4.0.0-beta-4-SNAPSHOT) fails with a
NullPointerExceptionin thePluginsMetadataGeneratorclass of the "Maven Compat (deprecated)" module. The issue seems more serious than a missing null check, because according the sanity check at line 137, the plugin is operating on the wrong artifact. However, this issue is not related to this commit. Testing with the commit before this one produces the same result. Building with Maven 3 works fine.https://issues.apache.org/jira/browse/MNG-8197