Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MNG-6776] Inconsistent list of parameters for MojoDescriptor #584

Merged
merged 2 commits into from
Feb 14, 2022

Conversation

cstamas
Copy link
Member

@cstamas cstamas commented Oct 12, 2021

It may lead to confusion as parameters (list) and
parametersMap (map) may "fall apart" easily.

Also, parametersMap did not honor parameter
ordering while parameters list makes it look
that order is important.
Simply, rebuild the map always and retain
ordering as well.

Added UT and also removed some cruft provided
by java8.


https://issues.apache.org/jira/browse/MNG-7309
See #291

@michael-o
Copy link
Member

Is there a JIRA issue for this?

@cstamas
Copy link
Member Author

cstamas commented Oct 12, 2021

Nope, just @slachiewicz throwed together a test, it all started there #291

@michael-o
Copy link
Member

Ah ok, maybe this should be in one PR?

@cstamas cstamas changed the title Fix MojoDescriptor [MNG-7309] Remove redundant MojoDescriptor parameterMap Oct 15, 2021
@cstamas cstamas marked this pull request as ready for review October 15, 2021 12:03
It may lead to confusion as parameters (list) and
parametersMap (map) may "fall apart" easily.

Also, parametersMap did not honor parameter
ordering while parameters list makes it look
that order is important.
Simply, rebuild the map always and retain
ordering as well.

Added UT and also removed some cruft provided
by java8.
@cstamas cstamas changed the title [MNG-7309] Remove redundant MojoDescriptor parameterMap [MNG-6776] Inconsistent list of parameters for MojoDescriptor Dec 2, 2021
@cstamas cstamas requested a review from gnodet December 2, 2021 20:46
@cstamas
Copy link
Member Author

cstamas commented Dec 2, 2021

@gnodet @michael-o @slachiewicz pls review (again Guillaume), cleaned up, pulled in @slachiewicz UT

@cstamas cstamas merged commit cc51006 into master Feb 14, 2022
@cstamas cstamas deleted the do-not-keep-parameters-map branch February 14, 2022 11:26
asfgit pushed a commit that referenced this pull request Jan 2, 2024
It may lead to confusion as parameters (list) and
parametersMap (map) may "fall apart" easily.

Also, parametersMap did not honor parameter
ordering while parameters list makes it look
that order is important.
Simply, rebuild the map always and retain
ordering as well.

Added UT and also removed some cruft provided
by java8.

---

https://issues.apache.org/jira/browse/MNG-7309
asfgit pushed a commit that referenced this pull request Jan 3, 2024
It may lead to confusion as parameters (list) and
parametersMap (map) may "fall apart" easily.

Also, parametersMap did not honor parameter
ordering while parameters list makes it look
that order is important.
Simply, rebuild the map always and retain
ordering as well.

Added UT and also removed some cruft provided
by java8.

Co-authored-by: Marc Wrobel <[email protected]>
Co-authored-by: Slawomir Jaranowski <[email protected]>

---

https://issues.apache.org/jira/browse/MNG-7309
asfgit pushed a commit that referenced this pull request Jan 6, 2024
It may lead to confusion as parameters (list) and
parametersMap (map) may "fall apart" easily.

Also, parametersMap did not honor parameter
ordering while parameters list makes it look
that order is important.
Simply, rebuild the map always and retain
ordering as well.

Added UT and also removed some cruft provided
by java8.

Co-authored-by: Marc Wrobel <[email protected]>
Co-authored-by: Slawomir Jaranowski <[email protected]>

(cherry picked from commit cc51006)
(cherry picked from commit 5ce5591)
(cherry picked from commit 47e2d68)
---

https://issues.apache.org/jira/browse/MNG-7309
asfgit pushed a commit that referenced this pull request Jan 6, 2024
It may lead to confusion as parameters (list) and
parametersMap (map) may "fall apart" easily.

Also, parametersMap did not honor parameter
ordering while parameters list makes it look
that order is important.
Simply, rebuild the map always and retain
ordering as well.

Added UT and also removed some cruft provided
by java8.

Co-authored-by: Marc Wrobel <[email protected]>
Co-authored-by: Slawomir Jaranowski <[email protected]>

(cherry picked from commit cc51006)
(cherry picked from commit 5ce5591)
(cherry picked from commit 47e2d68)
---

https://issues.apache.org/jira/browse/MNG-7309
asfgit pushed a commit that referenced this pull request Jan 6, 2024
It may lead to confusion as parameters (list) and
parametersMap (map) may "fall apart" easily.

Also, parametersMap did not honor parameter
ordering while parameters list makes it look
that order is important.
Simply, rebuild the map always and retain
ordering as well.

Added UT and also removed some cruft provided
by java8.

Co-authored-by: Marc Wrobel <[email protected]>
Co-authored-by: Slawomir Jaranowski <[email protected]>

(cherry picked from commit cc51006)
(cherry picked from commit 5ce5591)
(cherry picked from commit 47e2d68)
---

https://issues.apache.org/jira/browse/MNG-7309
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants