Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MNG-7193] Introduce MAVEN_ARGS environment variable #637

Closed
wants to merge 1 commit into from

Conversation

michael-o
Copy link
Member

Add args directly after the class name and leave users the option to override
with maven.config or CLI args.

This closes #637

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [MNG-XXX] - Fixes bug in ApproximateQuantiles,
    where you replace MNG-XXX with the appropriate JIRA issue. Best practice
    is to use the JIRA issue title in the pull request title and in the first line of the
    commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the Core IT successfully.

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

Copy link
Contributor

@rfscholte rfscholte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be documented somewhere as well.

@michael-o
Copy link
Member Author

This needs to be documented somewhere as well.

You are right. I will locate the appropriate document before merging this.

Copy link
Contributor

@mthmulders mthmulders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did the same test as three weeks ago but this time it behaves as expected 👍🏻

@mthmulders
Copy link
Contributor

I guess this means we can close #602?

@michael-o
Copy link
Member Author

I will supersede #602 with two alternative PRs.

asfgit pushed a commit that referenced this pull request Dec 21, 2021
Add args directly after the class name and leave users the option to override
with maven.config or CLI args.

This closes #637
@michael-o
Copy link
Member Author

@rfscholte Updated inline scripts and add apache/maven-site#280.

Add args directly after the class name and leave users the option to override
with maven.config or CLI args.

This closes #637
@rfscholte
Copy link
Contributor

Must also end up in https://github.com/apache/maven-wrapper

@michael-o
Copy link
Member Author

@rfscholte While I agree those scripts are completely Maven 3. I.e, they would require to migrate to Maven 4 approach first. (reduced set). Cherry-picking pieces does not make sense. I can create a ticket to track this.

@asfgit asfgit closed this in 6257b33 Dec 23, 2021
@michael-o michael-o deleted the MNG-7193 branch December 25, 2021 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants