-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MNG-7193] Introduce MAVEN_ARGS environment variable #637
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to be documented somewhere as well.
You are right. I will locate the appropriate document before merging this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did the same test as three weeks ago but this time it behaves as expected 👍🏻
I guess this means we can close #602? |
I will supersede #602 with two alternative PRs. |
Add args directly after the class name and leave users the option to override with maven.config or CLI args. This closes #637
@rfscholte Updated inline scripts and add apache/maven-site#280. |
Add args directly after the class name and leave users the option to override with maven.config or CLI args. This closes #637
Must also end up in https://github.com/apache/maven-wrapper |
@rfscholte While I agree those scripts are completely Maven 3. I.e, they would require to migrate to Maven 4 approach first. (reduced set). Cherry-picking pieces does not make sense. I can create a ticket to track this. |
Add args directly after the class name and leave users the option to override
with maven.config or CLI args.
This closes #637
Following this checklist to help us incorporate your
contribution quickly and easily:
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
[MNG-XXX] - Fixes bug in ApproximateQuantiles
,where you replace
MNG-XXX
with the appropriate JIRA issue. Best practiceis to use the JIRA issue title in the pull request title and in the first line of the
commit message.
mvn clean verify
to make sure basic checks pass. A more thorough check willbe performed on your pull request automatically.
If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.
I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004
In any other case, please file an Apache Individual Contributor License Agreement.