Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Updated Symbol tutorial with Gluon #12190

Merged
merged 6 commits into from
Sep 20, 2018

Conversation

thomelane
Copy link
Contributor

Description

Added references to Gluon in the Symbol tutorial, i.e. mention that it is used after hybridization.

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes): tiny change.
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Updated Symbol tutorial

thomelane and others added 3 commits July 25, 2018 11:51
Corrected a race condition with stopping profiling. Added mx.nd.waitall to ensure all operations have completed, including GPU operations that might otherwise be missing.

Also added alternative code for context selection GPU vs CPU, that had error before on machines with nvidia-smi.
@nswamy
Copy link
Member

nswamy commented Aug 21, 2018

@thomelane could you please push an empty commit/rebase to your branch. We had some problem in the CI pipeline and needs rebase. I can merge after it passes CI

@eric-haibin-lin eric-haibin-lin added the pr-awaiting-testing PR is reviewed and waiting CI build and test label Aug 26, 2018
@sandeep-krishnamurthy
Copy link
Contributor

Looks good thanks.
@nswamy - merging this on your behalf.

@sandeep-krishnamurthy sandeep-krishnamurthy merged commit 7797584 into apache:master Sep 20, 2018
@thomelane thomelane deleted the tutorial_symbol branch January 11, 2019 19:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr-awaiting-testing PR is reviewed and waiting CI build and test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants