Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

update C++ example so it is easier to run #12397

Merged
merged 2 commits into from
Sep 10, 2018

Conversation

aaronmarkham
Copy link
Contributor

Description

This PR updates a C++ image classification example, fixing grammar, and adding instructions so it can be run through the first time.
Currently, you will segfault and fail a few times until you read through all of the tips and troubleshoot.

Comments

Maybe this example should be moved into the cpp-package folder? Or, should the examples in the cpp-package folder be moved out to the general /mxnet/example folder?

Maybe this should use something from the model zoo instead of linking to old models on data.mxnet.io?

We can always do either of these later and just get this fixed up for now...

Copy link
Contributor

@lupesko lupesko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One doc update. Rest looks good.

example/image-classification/predict-cpp/README.md Outdated Show resolved Hide resolved
@indhub indhub merged commit 20a087f into apache:master Sep 10, 2018
aaronmarkham added a commit to aaronmarkham/incubator-mxnet that referenced this pull request Sep 11, 2018
* update example so it is easier to run

* updated per feedback; removed CPP prerequisite
anirudh2290 pushed a commit to anirudh2290/mxnet that referenced this pull request Sep 19, 2018
* update example so it is easier to run

* updated per feedback; removed CPP prerequisite
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants