-
Notifications
You must be signed in to change notification settings - Fork 6.8k
update with release notes for 1.4.0 release #13657
Conversation
Please wait a moment to merge the PR. |
@srochel could you help add the below description into the new feature parts of r1.4? @larroy @aaronmarkham could you help take a reveiw for the contents? Thanks in advance. MKDNN backend: Graph optimization and Quantization (experimental) Two advanced features, graph optimization (operator fusion) and reduced-precision (INT8) computation, are introduced to MKL-DNN backend in this release (#12530, #13297, #13260).
MKL-DNN backend takes advantage of MXNet subgraph to implement the most of possible operator fusions for inference, such as Convolution + ReLU, Batch Normalization folding, etc. When using mxnet-mkl package, users can easily enable this feature by setting
Performance of reduced-precision (INT8) computation is also dramatically improved after the graph optimization feature is applied on CPU Platforms. Various models are supported and can benefit from reduced-precision computation, including symbolic models, Gluon models and even custom models. Users can run most of the pre-trained models with only a few lines of commands and a new quantization script Please find detailed information and performance/accuracy numbers here: MKLDNN README, quantization README and design proposal |
addressed feedback from December 17 except ngraph related comments.
@pengzhao-intel added your change request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some grammar and clarification and consistency updates in the overview sections.
The bug fix section seems like it could be more useful with some organization and clarity in the titles. I realize a lot of this is scraped and researching/updating is time consuming.
Some stuff in the big PR lists could be recategorized... even multi-categorized.
I don't think the JIRA tags are helpful in the descriptions in these release notes.
I wonder about keeping things in the notes that were reverted. Should these stay?
I think the test section has so much back and forth with enable/disable that it not helpful. A status would be nice - what's new, what's fixed, what's disabled now in this release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some grammar and clarification and consistency updates in the overview sections.
The bug fix section seems like it could be more useful with some organization and clarity in the titles. I realize a lot of this is scraped and researching/updating is time consuming.
Some stuff in the big PR lists could be recategorized... even multi-categorized.
I don't think the JIRA tags are helpful in the descriptions in these release notes.
I wonder about keeping things in the notes that were reverted. Should these stay?
I think the test section has so much back and forth with enable/disable that it not helpful. A status would be nice - what's new, what's fixed, what's disabled now in this release.
I kept getting nginx 405 errors from github when trying to submit this review (it was a lot of change requests >100) - it went through on the third try, so hopefully the review is all there. |
Thanks for the corrections @srochel |
@mxnet-label-bot Add labels [pr-awaiting-response, Doc] |
Co-Authored-By: srochel <[email protected]>
Co-Authored-By: srochel <[email protected]>
Co-Authored-By: srochel <[email protected]>
Co-Authored-By: srochel <[email protected]>
Co-Authored-By: srochel <[email protected]>
Co-Authored-By: srochel <[email protected]>
Co-Authored-By: srochel <[email protected]>
Co-Authored-By: srochel <[email protected]>
Co-Authored-By: srochel <[email protected]>
Co-Authored-By: srochel <[email protected]>
Co-Authored-By: srochel <[email protected]>
removed nGraph integration from 1.4.0 release notes
Co-Authored-By: srochel <[email protected]>
Co-Authored-By: srochel <[email protected]>
Co-Authored-By: srochel <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
adopting all of Aaron's change proposals.
@srochel Please let me know when I should merge this PR |
updates to address feedback from szha@, pengzhao-intel@ and TaoLv@
Co-Authored-By: srochel <[email protected]>
Co-Authored-By: srochel <[email protected]>
Co-Authored-By: srochel <[email protected]>
Co-Authored-By: srochel <[email protected]>
Co-Authored-By: srochel <[email protected]>
Addressed more of Aaron's comments and requests.
12/18 4pm - I addressed most of Aaron feedback. I will work with him tomorrow to resolve the remaining feedback from him. Issues from all other code reviewers are addressed. |
Address all of Aaron's feedback, except question regarding Jira and Test section.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a table of contents at the top.
I also reviewed the new MKLDNN, Graph optimization and quantization sections.
Co-Authored-By: srochel <[email protected]>
Co-Authored-By: srochel <[email protected]>
addressed all feedback as of 12/19 11.30am. |
@srochel after I get this merged into the 1.4.x branch, what's procedure to get it added to the master branch ? |
* Add embedding to print_summary (#12796) | ||
* Allow foreach on input with 0 length (#12471) | ||
* [MXNET-360]auto convert str to bytes in img.imdecode when py3 (#10697) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add
- Fix unpicklable transform_first on windows ([gluon][transform]fix unpicklable transform_first on windows #13686 )
@aaronmarkham there was open comment by @astonzhang which I think should be addressed. What's your plan? |
Ah I didn't see Aston's comment. I can add that myself. |
Don't worry, it has already been added: |
Description
update with release notes for 1.4.0 release
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Comments