[RFC] Fix console echo handling #2233
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @dwld could you please checked if this solution fixes problem that you detected? |
kasjer
force-pushed
the
kasjer/fix-console-echo-handling
branch
from
3c88a94
to
d029f1d
Compare
Funny one, the style checker does not know what "fall through" means and thinks that your comment applies to the next |
Hi @kasjer, thanks for your work. In my current project, I do not require NLIP. I just tested this PR with CONSOLE_ECHO: 0 and CONSOLE_NLIP: 0. Unfortunately, the new line is still there, since it is printed by lines 1168 and 1169 in console.c ( Maybe we could add an option like your introduced CONSOLE_NLIP_ECHO_LF for NLIP to enable/disable (whatever is more reasonable) the new line echo in non-NLIP mode. |
kasjer
force-pushed
the
kasjer/fix-console-echo-handling
branch
from
d029f1d
to
1a0809d
Compare
Add syscfg switch that allows builds with NLIP code disabled. It should reduce console code size if NLIP is not needed.
Function console_echo(1) was called in some cases during nlip handling. This resulted in console echo being turned on while user code could turn it off on purpose before. Now console echo will not turned of if user setting/code did not wanted to have echo enabled.
Code was echoing back LF character even when application requested to silence non-NLIP data on input. Now this behaviour is still possible but require explicit setting CONSOLE_NLIP_ECHO_LF which is disabled by default.
Prompt is output on console that did not originated in application code. This is similar to echo characters that goes out of console outside of application decision. This disable printing prompt when echo is turned off so console code does not add anything to the output.
kasjer
force-pushed
the
kasjer/fix-console-echo-handling
branch
from
1a0809d
to
5abaebe
Compare
Style check summaryOur coding style is here!sys/console/minimal/src/console.c@@ -323,7 +323,7 @@
ev = NULL;
console_is_interactive = echo;
return 0;
- /* Ignore characters if there's no more buffer space */
+ /* Ignore characters if there's no more buffer space */
} else if (byte == CONSOLE_NLIP_PKT_START2) {
/* Disable echo to not flood the UART */
console_is_interactive = 0;
@@ -352,9 +352,9 @@
#endif
default:
insert_char(&input->line[cur], byte, end);
- /* Falls through. */
+ /* Falls through. */
case '\r':
- /* Falls through. */
+ /* Falls through. */
case '\n':
if (byte == '\n' && prev_endl == '\r') {
/* handle double end line chars */ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Echo could be turned on after some nlip bytes handling, now if user code disabled echo with console_echo(0) it will not be enabled in nlip code.
Additionally nlip handling can be disabled to reduce code size.
When application calls console_echo(0), console will not insert anything to the output by itself (echo, prompt, completion)