Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NIFI-10616 Resolve Reproducible ANTLR3 and JAXB Build Issues #6500

Closed
wants to merge 1 commit into from

Conversation

hboutemy
Copy link
Member

@hboutemy hboutemy commented Oct 8, 2022

Summary

NIFI-10616

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using mvn clean install -P contrib-check
    • JDK 8
    • JDK 11
    • JDK 17

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

Copy link
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @hboutemy!

It looks like discussion is still going on regarding the ANTLR3 issue 209. The maven-replacer-plugin approach makes sense, but it seems that the plugin is not actively maintained, which is somewhat concerning.

What do you think about scoping the current changes to the JAXB2 configuration, and waiting for a resolution on the ANTLR3 issue for now?

@hboutemy
Copy link
Member Author

waiting for ANTLR3 upstream solution seems to take ages: I don't think it's worth waiting for it

@exceptionfactory exceptionfactory added the hacktoberfest-accepted Hacktoberfest Accepted label Oct 31, 2022
@exceptionfactory
Copy link
Contributor

Thanks for the reply @hboutemy, based on the status of ANTLR 3 antlr/antlr3#209, moving forward with this solution looks good for now.

@exceptionfactory exceptionfactory changed the title NIFI-10616 fix some unreproducible bits NIFI-10616 Resolve Reproducible ANTLR3 and JAXB Build Issues Oct 31, 2022
@hboutemy hboutemy deleted the NIFI-10616 branch November 28, 2022 23:29
lizhizhou pushed a commit to lizhizhou/nifi that referenced this pull request Jan 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Hacktoberfest Accepted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants