NIFI-12245: Removed deprecations around flow registry clients #7899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonbence
reviewed
Oct 20, 2023
| @@ -502,7 +502,7 @@ private String determineRegistryId(final VersionedFlowCoordinates coordinates) { | |||
| } | |||
| } | |||
|
|
|||
| final String location = coordinates.getStorageLocation() == null ? coordinates.getRegistryUrl() : coordinates.getStorageLocation(); | |||
| final String location = coordinates.getStorageLocation(); | |||
| if (location == null) { | |||
There was a problem hiding this comment.
I think the empty storage location is not valid (at least not with url removed)
pvillard31
requested changes
Oct 23, 2023
There was a problem hiding this comment.
Warning: src/main/java/org/apache/nifi/web/api/ControllerResource.java:[108,8] (imports) UnusedImports: Unused import - java.util.HashMap.
Warning: src/main/java/org/apache/nifi/web/api/ControllerResource.java:[110,8] (imports) UnusedImports: Unused import - java.util.Optional.
|
Build is successfull, basic test cases (including cases with embedded flow) looks good, merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
NIFI-00000
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000Pull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
mvn clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation