telenet: fix telenet compilation error when system_nsh is not enabled #2713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elnetd.c:57:5: error: 'CONFIG_SYSTEM_TELNETD_SESSION_STACKSIZE' undeclared (first use in this function); did you mean 'CONFIG_SYSTEM_TELNETD_SESSION_PRIORITY'?
57 | CONFIG_SYSTEM_TELNETD_SESSION_STACKSIZE,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
| CONFIG_SYSTEM_TELNETD_SESSION_PRIORITY
Signed-off-by: yinshengkai <[email protected]>
GUIDINGLI
approved these changes
Oct 13, 2024
|
Sorry there's a typo in the PR title: "telenet" should be "telnet". Thanks :-) |
| @@ -40,6 +40,6 @@ config SYSTEM_TELNETD_SESSION_PRIORITY | |||
|
|
|||
| config SYSTEM_TELNETD_SESSION_STACKSIZE | |||
| int "Telnetd session task stack size" | |||
| default SYSTEM_NSH_STACKSIZE | |||
| default DEFAULT_TASK_STACKSIZE | |||
|
Already handle at: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
telenet: fix telenet compilation error when system_nsh is not enabled
telnetd.c:57:5: error: 'CONFIG_SYSTEM_TELNETD_SESSION_STACKSIZE' undeclared (first use in this function); did you mean 'CONFIG_SYSTEM_TELNETD_SESSION_PRIORITY'?
57 | CONFIG_SYSTEM_TELNETD_SESSION_STACKSIZE,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
| CONFIG_SYSTEM_TELNETD_SESSION_PRIORITY
Impact
Testing