Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cibuild.sh: Using GCC from xPack for riscv #10702

Merged
merged 1 commit into from
Sep 19, 2023
Merged

Conversation

no1wudi
Copy link
Contributor

@no1wudi no1wudi commented Sep 19, 2023

Summary

Follow #10699

Impact

CI

Testing

CI

@pkarashchenko
Copy link
Contributor

Let's merge this PR and give CI a try to rebuild docker images. In case if build fails I will revert it

@pkarashchenko pkarashchenko merged commit 7d3f11a into apache:master Sep 19, 2023
24 of 26 checks passed
@pkarashchenko
Copy link
Contributor

@xiaoxiang781216 could we hold on the further merges until https://github.com/apache/nuttx/actions/runs/6234041079/job/16920715873 is finished? I want to get a feedback from the current change

@pkarashchenko
Copy link
Contributor

Seems like the error with C++ still persists

@pkarashchenko
Copy link
Contributor

====================================================================================
Configuration/Tool: esp32c3-devkit/cxx
------------------------------------------------------------------------------------
  Cleaning...
make[1]: warning: jobserver unavailable: using -j1.  Add '+' to parent make rule.
make[1]: warning: jobserver unavailable: using -j1.  Add '+' to parent make rule.
  Configuring...
make[1]: warning: jobserver unavailable: using -j1.  Add '+' to parent make rule.
make[1]: warning: jobserver unavailable: using -j1.  Add '+' to parent make rule.
  Building NuttX...
In file included from /github/workspace/sources/nuttx/include/libcxx/algorithm:650,
                 from libcxx/src/algorithm.cpp:9:
Error: /github/workspace/sources/nuttx/include/libcxx/type_traits:1729:8: error: expected identifier before '__is_convertible'
 1729 | struct __is_convertible
      |        ^~~~~~~~~~~~~~~~
Error: /github/workspace/sources/nuttx/include/libcxx/type_traits:1729:8: error: expected unqualified-id before '__is_convertible'
Error: /github/workspace/sources/nuttx/include/libcxx/type_traits:1735:40: error: expected identifier before '__is_convertible'
 1735 | template <class _T1, class _T2> struct __is_convertible<_T1, _T2, 0, 1> : public false_type {};
      |                                        ^~~~~~~~~~~~~~~~
Error: /github/workspace/sources/nuttx/include/libcxx/type_traits:1735:40: error: expected unqualified-id before '__is_convertible'
Error: /github/workspace/sources/nuttx/include/libcxx/type_traits:1736:40: error: expected identifier before '__is_convertible'
 1736 | template <class _T1, class _T2> struct __is_convertible<_T1, _T2, 1, 1> : public false_type {};

@no1wudi
Copy link
Contributor Author

no1wudi commented Sep 19, 2023

@pkarashchenko Seems the docker image is not up to date, still use the gcc 13 that merged yesterday.

@xiaoxiang781216
Copy link
Contributor

I create a patch(#10717) try to update the docker image again. Let's see what's happen.

@lupyuen lupyuen mentioned this pull request Aug 26, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants