Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coresight: add init coresight driver framework #11605

Merged
merged 13 commits into from
Sep 13, 2024

Conversation

leo11261
Copy link
Contributor

Summary

add init coresight driver framework

Impact

debug features

Testing

ETM->FUNNEL->ETF->ETR->psram
STM->FUNNEL->ETF->ETR->psram

coresight devices above are tested, and can produce trace data.

drivers/coresight/coresight_core.c Show resolved Hide resolved
include/nuttx/coresight/coresight.h Outdated Show resolved Hide resolved
drivers/coresight/coresight_common.c Show resolved Hide resolved
drivers/coresight/coresight_common.c Show resolved Hide resolved
drivers/coresight/coresight_common.c Show resolved Hide resolved
drivers/coresight/coresight_common.c Show resolved Hide resolved
drivers/coresight/coresight_common.c Show resolved Hide resolved
Copy link
Contributor

@acassis acassis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please include some basic documentation talking about these debug features: "how, when and why" it should be used. I saw ARM has a good documentation about it: https://developer.arm.com/documentation/102520/latest/ so maybe you could include it as reference and explain which benefits this support on NuttX brings to user and how they can use it for everyday debugging, etc.

@acassis
Copy link
Contributor

acassis commented Sep 11, 2024

@leo11261 any news?

@leo11261
Copy link
Contributor Author

@leo11261 any news?

i will update them in few days.

@leo11261 leo11261 force-pushed the coresight branch 2 times, most recently from f72e842 to d493e2c Compare September 12, 2024 11:07
@leo11261
Copy link
Contributor Author

Please include some basic documentation talking about these debug features: "how, when and why" it should be used. I saw ARM has a good documentation about it: https://developer.arm.com/documentation/102520/latest/ so maybe you could include it as reference and explain which benefits this support on NuttX brings to user and how they can use it for everyday debugging, etc.

I have already added one in latest commit,please refer to 6747f57

@leo11261 leo11261 closed this Sep 12, 2024
@leo11261 leo11261 reopened this Sep 12, 2024
@xiaoxiang781216 xiaoxiang781216 merged commit d8d7f3c into apache:master Sep 13, 2024
31 of 56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants