Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github/workflows: add PR size labeler #13542

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

raiden00pl
Copy link
Contributor

@raiden00pl raiden00pl commented Sep 19, 2024

Summary

Add workflow that assigns labels based on the PR's size.
Based on https://github.com/marketplace/actions/pull-request-size-labeler

This is an external action, but it's used also in Apache Mynewt-nimble project, so I think it's ok: https://github.com/apache/mynewt-nimble/blob/master/.github/workflows/labeler.yml

This allows easy filtering of PR by the size of changes

Impact

Each PR will have a label assigned depending on its size:
xs_label: 'Size: XS', max size = 10
s_label: 'Size: S', max size = 100
m_label: 'Size: M', max size = 500
l_label: 'Size: L', max size = 1000
xl_label: 'Size: XL', > 1000

Testing

tested on my private nuttx repo here https://github.com/raiden00pl/nuttx/pulls

image

@raiden00pl raiden00pl changed the title Pr label test3 github/workflows: add PR size labeler Sep 19, 2024
@nuttxpr
Copy link

nuttxpr commented Sep 19, 2024

[Experimental Bot, please feedback here]

I need the content of the actual Pull Request (PR) to assess if it meets the NuttX requirements. Please provide the following:

  • Link to the PR: This is the most helpful. I can directly review the PR content on GitHub.
  • PR Description: If you can't share the link, copy and paste the full PR description.

With this information, I can compare it to the requirements and give you a concise answer.

@raiden00pl raiden00pl force-pushed the pr_label_test3 branch 2 times, most recently from 8bca19a to 3c09f75 Compare September 19, 2024 10:16
@raiden00pl raiden00pl marked this pull request as draft September 19, 2024 10:23
@raiden00pl raiden00pl marked this pull request as ready for review September 19, 2024 10:41
@jerpelea
Copy link
Contributor

@raiden00pl

please add

  • SPDX-License-Identifier: Apache-2.0

in front of the Apache license

Thanks

add workflow that assigns labels based on the PR's size
@xiaoxiang781216 xiaoxiang781216 merged commit 31b2438 into apache:master Sep 19, 2024
20 of 28 checks passed
@raiden00pl raiden00pl deleted the pr_label_test3 branch September 20, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants