Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Libs: migrate to SPDX identifier #13769

Merged
merged 6 commits into from
Oct 1, 2024
Merged

Conversation

jerpelea
Copy link
Contributor

Summary

Most tools used for compliance and SBOM generation use SPDX identifiers
This change brings us a step closer to an easy SBOM generation.
Some files were converted to Apache license

Ignored (will be evaluated later)
BSD-4-clause
libs/libc/stdlib/lib_bsearch.c
libs/libc/stdlib/lib_qsort.c

Impact

SPDX

Testing

CI

Most tools used for compliance and SBOM generation use SPDX identifiers
This change brings us a step closer to an easy SBOM generation.

Signed-off-by: Alin Jerpelea <[email protected]>
Most tools used for compliance and SBOM generation use SPDX identifiers
This change brings us a step closer to an easy SBOM generation.

Signed-off-by: Alin Jerpelea <[email protected]>
Most tools used for compliance and SBOM generation use SPDX identifiers
This change brings us a step closer to an easy SBOM generation.

Signed-off-by: Alin Jerpelea <[email protected]>
Most tools used for compliance and SBOM generation use SPDX identifiers
This change brings us a step closer to an easy SBOM generation.

Signed-off-by: Alin Jerpelea <[email protected]>
Most tools used for compliance and SBOM generation use SPDX identifiers
This change brings us a step closer to an easy SBOM generation.

Signed-off-by: Alin Jerpelea <[email protected]>
Most tools used for compliance and SBOM generation use SPDX identifiers
This change brings us a step closer to an easy SBOM generation.

Signed-off-by: Alin Jerpelea <[email protected]>
@github-actions github-actions bot added Area: OS Components OS Components issues Size: M The size of the change in this PR is medium labels Sep 30, 2024
@nuttxpr
Copy link

nuttxpr commented Sep 30, 2024

[Experimental Bot, please feedback here]

This PR does not meet the NuttX requirements. Here's why:

Missing Information:

  • Summary:
    • The specific functional code changes are unclear. Be explicit about what files were modified to include SPDX identifiers.
    • Explain how the changes bring you closer to SBOM generation.
  • Impact:
    • Is new feature added? Is existing feature changed? - Unclear.
    • Impact on user: - Unclear. Will users interact with SBOM generation?
    • Impact on build: - Unclear. Does adding SPDX identifiers impact the build process itself?
    • Impact on hardware: - Unclear. Do SPDX additions impact any hardware dependencies?
    • Impact on documentation: - Documentation needs to be updated if you expect others to use the SBOM generation.
    • Impact on security: - Licensing changes have security implications. Address the BSD-4-clause files in this PR. "Evaluated later" is not acceptable.
    • Impact on compatibility: - Unclear. Do licensing changes affect compatibility with other software?
  • Testing:
    • Build Host(s): - Provide specific details: OS, CPU architecture, compiler version.
    • Target(s): - Provide details: Specific architectures, boards, and configurations.
    • Testing logs before change/Testing logs after change: - These sections are empty. You must include logs to demonstrate the impact of your changes.

Recommendations:

  1. Be Specific: Provide clear and detailed information about your changes in all sections.
  2. Address Licensing: Do not defer licensing issues. The BSD-4-clause files need resolution within this PR.
  3. Provide Evidence: Include testing logs that demonstrate the functionality before and after your changes.

Remember: A complete and informative PR will significantly speed up the review process.

@xiaoxiang781216 xiaoxiang781216 merged commit 6b5dddd into apache:master Oct 1, 2024
28 of 29 checks passed
@jerpelea jerpelea deleted the libs branch October 1, 2024 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: OS Components OS Components issues Size: M The size of the change in this PR is medium
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants