-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update stream relative, fix mtd&blk stream readback before block update. decrese int use in stream to handle FS_LARGEFILE #14778
Conversation
[Experimental Bot, please feedback here] Yes, this PR appears to meet the NuttX requirements, although the provided information is minimal. It would be stronger with more detail. Here's a breakdown: Strengths:
Weaknesses & Missing Information:
Recommendation: While the core elements are present, this PR description needs more detail to ensure thorough review and avoid potential problems. Expand the "Impact" and "Testing" sections considerably, providing concrete examples and data. Add issue references. A more detailed PR will increase confidence in the changes and streamline the review process. |
Signed-off-by: buxiasen <[email protected]>
Signed-off-by: buxiasen <[email protected]>
offset int -> offset, len int -> size_t, ret int -> ssize_t Signed-off-by: buxiasen <[email protected]>
Signed-off-by: buxiasen <[email protected]>
Summary
int is not reliable when we use same code for cross platform.
replace with off_t,size_t,ssize_t should prefer.
offset int -> offset, len int -> size_t, ret int -> ssize_t
Also we should readback sector/block before operate to new sector/block,
for user only update partial case.
Impact
stream will able to support FS_LARGEFILE better cover >4GB devices.
if user use blk/mtd stream to update partial, the old data will be kept back.
Testing
CI-test, local arm-v8m prject, qemu-armv8a, ubutun sim:nsh