-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sched/mqueue: choose either mqueue or sysv at one time #14830
Conversation
[Experimental Bot, please feedback here] No, this PR does not fully meet the NuttX requirements. The provided information is far too brief. Here's a breakdown of what's missing:
In short: The PR needs significantly more detail to be considered complete. It needs to clearly articulate the problem being solved, the specific solution implemented, the full impact of the change, and provide concrete evidence (logs) that the change works as intended. |
@@ -49,12 +49,11 @@ | |||
|
|||
struct msgpool_s | |||
{ | |||
#ifndef CONFIG_DISABLE_MQUEUE | |||
#ifdef CONFIG_DISABLE_MQUEUE_SYSV |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but, the user could disable both message queue api
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ifneq (
CSRCS += mq_initialize.c mq_waitirq.c mq_recover.c
endif
when both disabled, mq_initialize.c will not compile
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if so, why we need change the source code
Only one initialization is needed for mqueue and sysv, use to reduce .bss usage. Signed-off-by: zhangyuan29 <[email protected]>
@@ -36,7 +36,7 @@ config DISABLE_MQUEUE | |||
|
|||
config DISABLE_MQUEUE_SYSV | |||
bool "Disable System V message queue support" | |||
default DISABLE_MQUEUE | |||
default y |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why need change the default setting
@@ -49,12 +49,11 @@ | |||
|
|||
struct msgpool_s | |||
{ | |||
#ifndef CONFIG_DISABLE_MQUEUE | |||
#ifdef CONFIG_DISABLE_MQUEUE_SYSV |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if so, why we need change the source code
Summary
Only one initialization is needed for mqueue and sysv,to reduce the usage of .bss.
Impact
mqueue
Testing
./tools/configure.sh sim:citest pass