feat: align fn root semantics; fix missing root for some services; …

…rm duplicated normalize ops (#5035)

* feat: align `fn root` semantics; fix missing root for some services

* typo and fmt

* chore

* fix name

* align more roots

* fix

* fix

* fix

* fix

core/src/raw/adapters/kv/backend.rs

@@ -50,8 +50,15 @@ where
     }
 
     /// Configure root within this backend.
-    pub fn with_root(mut self, root: &str) -> Self {
-        self.root = normalize_root(root);
+    pub fn with_root(self, root: &str) -> Self {
+        self.with_normalized_root(normalize_root(root))
+    }
+
+    /// Configure root within this backend.
+    ///
+    /// This method assumes root is normalized.
+    pub(crate) fn with_normalized_root(mut self, root: String) -> Self {
+        self.root = root;
         self
     }
 }

core/src/services/atomicserver/backend.rs

@@ -155,7 +155,7 @@ impl Builder for AtomicserverBuilder {
                     .with_context("service", Scheme::Atomicserver)
             })?,
         })
-        .with_root(&root))
+        .with_normalized_root(root))
     }
 }
 

core/src/services/azblob/backend.rs

@@ -150,9 +150,11 @@ impl AzblobBuilder {
     ///
     /// All operations will happen under this root.
     pub fn root(mut self, root: &str) -> Self {
-        if !root.is_empty() {
-            self.config.root = Some(root.to_string())
-        }
+        self.config.root = if root.is_empty() {
+            None
+        } else {
+            Some(root.to_string())
+        };
 
         self
     }

core/src/services/azdls/backend.rs

@@ -113,9 +113,11 @@ impl AzdlsBuilder {
     ///
     /// All operations will happen under this root.
     pub fn root(mut self, root: &str) -> Self {
-        if !root.is_empty() {
-            self.config.root = Some(root.to_string())
-        }
+        self.config.root = if root.is_empty() {
+            None
+        } else {
+            Some(root.to_string())
+        };
 
         self
     }

core/src/services/azfile/backend.rs

@@ -111,9 +111,11 @@ impl AzfileBuilder {
     ///
     /// All operations will happen under this root.
     pub fn root(mut self, root: &str) -> Self {
-        if !root.is_empty() {
-            self.config.root = Some(root.to_string())
-        }
+        self.config.root = if root.is_empty() {
+            None
+        } else {
+            Some(root.to_string())
+        };
 
         self
     }

core/src/services/cloudflare_kv/backend.rs

@@ -115,9 +115,12 @@ impl CloudflareKvBuilder {
 
     /// Set the root within this backend.
     pub fn root(mut self, root: &str) -> Self {
-        if !root.is_empty() {
-            self.config.root = Some(root.to_string())
-        }
+        self.config.root = if root.is_empty() {
+            None
+        } else {
+            Some(root.to_string())
+        };
+
         self
     }
 }
@@ -175,7 +178,7 @@ impl Builder for CloudflareKvBuilder {
             client,
             url_prefix,
         })
-        .with_root(&root))
+        .with_normalized_root(root))
     }
 }
 

core/src/services/cos/backend.rs

@@ -97,9 +97,11 @@ impl CosBuilder {
     ///
     /// All operations will happen under this root.
     pub fn root(mut self, root: &str) -> Self {
-        if !root.is_empty() {
-            self.config.root = Some(root.to_string())
-        }
+        self.config.root = if root.is_empty() {
+            None
+        } else {
+            Some(root.to_string())
+        };
 
         self
     }

core/src/services/d1/backend.rs

@@ -129,9 +129,12 @@ impl D1Builder {
     ///
     /// default: "/"
     pub fn root(mut self, root: &str) -> Self {
-        if !root.is_empty() {
-            self.config.root = Some(root.to_owned());
-        }
+        self.config.root = if root.is_empty() {
+            None
+        } else {
+            Some(root.to_string())
+        };
+
         self
     }
 
@@ -231,7 +234,7 @@ impl Builder for D1Builder {
             key_field,
             value_field,
         })
-        .with_root(&root))
+        .with_normalized_root(root))
     }
 }
 

core/src/services/dbfs/backend.rs

@@ -87,9 +87,11 @@ impl DbfsBuilder {
     ///
     /// All operations will happen under this root.
     pub fn root(mut self, root: &str) -> Self {
-        if !root.is_empty() {
-            self.config.root = Some(root.to_string())
-        }
+        self.config.root = if root.is_empty() {
+            None
+        } else {
+            Some(root.to_string())
+        };
 
         self
     }

core/src/services/dropbox/builder.rs

@@ -88,7 +88,12 @@ impl DropboxBuilder {
     ///
     /// Default to `/` if not set.
     pub fn root(mut self, root: &str) -> Self {
-        self.config.root = Some(root.to_string());
+        self.config.root = if root.is_empty() {
+            None
+        } else {
+            Some(root.to_string())
+        };
+
         self
     }
 

core/src/services/etcd/backend.rs

@@ -159,9 +159,12 @@ impl EtcdBuilder {
     ///
     /// default: "/"
     pub fn root(mut self, root: &str) -> Self {
-        if !root.is_empty() {
-            self.config.root = Some(root.to_owned());
-        }
+        self.config.root = if root.is_empty() {
+            None
+        } else {
+            Some(root.to_string())
+        };
+
         self
     }
 
@@ -246,7 +249,7 @@ impl Builder for EtcdBuilder {
             client,
             options,
         })
-        .with_root(root.as_str()))
+        .with_normalized_root(root))
     }
 }
 

core/src/services/foundationdb/backend.rs

@@ -113,7 +113,7 @@ impl Builder for FoundationdbBuilder {
                 .as_str(),
         );
 
-        Ok(FoundationdbBackend::new(Adapter { db, _network }).with_root(&root))
+        Ok(FoundationdbBackend::new(Adapter { db, _network }).with_normalized_root(root))
     }
 }
 

core/src/services/fs/backend.rs

@@ -62,9 +62,11 @@ pub struct FsBuilder {
 impl FsBuilder {
     /// Set root for backend.
     pub fn root(mut self, root: &str) -> Self {
-        if !root.is_empty() {
-            self.config.root = Some(root.to_string());
-        }
+        self.config.root = if root.is_empty() {
+            None
+        } else {
+            Some(root.to_string())
+        };
 
         self
     }

core/src/services/gcs/backend.rs

@@ -124,9 +124,11 @@ impl Debug for GcsBuilder {
 impl GcsBuilder {
     /// set the working directory root of backend
     pub fn root(mut self, root: &str) -> Self {
-        if !root.is_empty() {
-            self.config.root = Some(root.to_string())
-        }
+        self.config.root = if root.is_empty() {
+            None
+        } else {
+            Some(root.to_string())
+        };
 
         self
     }

core/src/services/gdrive/builder.rs

@@ -92,7 +92,12 @@ impl Debug for GdriveBuilder {
 impl GdriveBuilder {
     /// Set root path of GoogleDrive folder.
     pub fn root(mut self, root: &str) -> Self {
-        self.config.root = Some(root.to_string());
+        self.config.root = if root.is_empty() {
+            None
+        } else {
+            Some(root.to_string())
+        };
+
         self
     }
 

core/src/services/ghac/backend.rs

@@ -117,9 +117,11 @@ pub struct GhacBuilder {
 impl GhacBuilder {
     /// set the working directory root of backend
     pub fn root(mut self, root: &str) -> Self {
-        if !root.is_empty() {
-            self.config.root = Some(root.to_string())
-        }
+        self.config.root = if root.is_empty() {
+            None
+        } else {
+            Some(root.to_string())
+        };
 
         self
     }

core/src/services/gridfs/backend.rs

@@ -30,7 +30,7 @@ use tokio::sync::OnceCell;
 
 use crate::raw::adapters::kv;
 use crate::raw::new_std_io_error;
-use crate::raw::Access;
+use crate::raw::*;
 use crate::*;
 
 /// Config for Grid file system support.
@@ -114,9 +114,12 @@ impl GridFsBuilder {
     ///
     /// default: "/"
     pub fn root(mut self, root: &str) -> Self {
-        if !root.is_empty() {
-            self.config.root = Some(root.to_owned());
-        }
+        self.config.root = if root.is_empty() {
+            None
+        } else {
+            Some(root.to_string())
+        };
+
         self
     }
 
@@ -176,13 +179,22 @@ impl Builder for GridFsBuilder {
         };
         let chunk_size = self.config.chunk_size.unwrap_or(255);
 
+        let root = normalize_root(
+            self.config
+                .root
+                .clone()
+                .unwrap_or_else(|| "/".to_string())
+                .as_str(),
+        );
+
         Ok(GridFsBackend::new(Adapter {
             connection_string: conn,
             database,
             bucket,
             chunk_size,
             bucket_instance: OnceCell::new(),
-        }))
+        })
+        .with_normalized_root(root))
     }
 }
 

core/src/services/huggingface/backend.rs

@@ -159,9 +159,12 @@ impl HuggingfaceBuilder {
     ///
     /// All operations will happen under this root.
     pub fn root(mut self, root: &str) -> Self {
-        if !root.is_empty() {
-            self.config.root = Some(root.to_string());
-        }
+        self.config.root = if root.is_empty() {
+            None
+        } else {
+            Some(root.to_string())
+        };
+
         self
     }
 

core/src/services/ipfs/backend.rs

@@ -70,9 +70,11 @@ impl IpfsBuilder {
     /// - `/ipfs/bafybeibozpulxtpv5nhfa2ue3dcjx23ndh3gwr5vwllk7ptoyfwnfjjr4q/` (IPFS with  CID v1)
     /// - `/ipns/opendal.apache.org/` (IPNS)
     pub fn root(mut self, root: &str) -> Self {
-        if !root.is_empty() {
-            self.config.root = Some(root.to_string())
-        }
+        self.config.root = if root.is_empty() {
+            None
+        } else {
+            Some(root.to_string())
+        };
 
         self
     }

core/src/services/libsql/backend.rs

@@ -137,9 +137,12 @@ impl LibsqlBuilder {
     ///
     /// default: "/"
     pub fn root(mut self, root: &str) -> Self {
-        if !root.is_empty() {
-            self.config.root = Some(root.to_string());
-        }
+        self.config.root = if root.is_empty() {
+            None
+        } else {
+            Some(root.to_string())
+        };
+
         self
     }
 
@@ -215,7 +218,7 @@ impl Builder for LibsqlBuilder {
             key_field,
             value_field,
         })
-        .with_root(&root))
+        .with_normalized_root(root))
     }
 }
 

core/src/services/memcached/backend.rs

@@ -78,9 +78,12 @@ impl MemcachedBuilder {
     ///
     /// default: "/"
     pub fn root(mut self, root: &str) -> Self {
-        if !root.is_empty() {
-            self.config.root = Some(root.to_owned());
-        }
+        self.config.root = if root.is_empty() {
+            None
+        } else {
+            Some(root.to_string())
+        };
+
         self
     }
 
@@ -172,7 +175,7 @@ impl Builder for MemcachedBuilder {
             conn,
             default_ttl: self.config.default_ttl,
         })
-        .with_root(&root))
+        .with_normalized_root(root))
     }
 }