Skip to content

Commit

Permalink
fix(services/s3): Fix part number for AWS S3 (#1450)
Browse files Browse the repository at this point in the history
Signed-off-by: Xuanwo <[email protected]>
  • Loading branch information
Xuanwo authored Mar 1, 2023
1 parent eeb95c9 commit 25af9fe
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion src/services/s3/writer.rs
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,8 @@ impl oio::Write for S3Writer {
let upload_id = self.upload_id.as_ref().expect(
"Writer doesn't have upload id, but users trying to call append, must be buggy",
);
let part_number = self.parts.len();
// AWS S3 requires part numbder must between [1..=10000]
let part_number = self.parts.len() + 1;

let mut req = self.backend.s3_upload_part_request(
&self.path,
Expand Down

2 comments on commit 25af9fe

@github-actions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deploy preview for opendal ready!

✅ Preview
https://opendal-mmgq1h6eg-databend.vercel.app

Built with commit 25af9fe.
This pull request is being automatically deployed with vercel-action

@github-actions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Rust Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: 25af9fe Previous: eeb95c9 Ratio
service_memory_write_once/256 KiB 38584 ns/iter (± 1301) 18006 ns/iter (± 26) 2.14

This comment was automatically generated by workflow using github-action-benchmark.

CC: @Xuanwo

Please sign in to comment.