refacor(services/fs): Make normalized path check optional (#1242)

* Remove not needed benches Signed-off-by: Xuanwo <[email protected]> * refacor(services/fs): Make normalized path check optional Signed-off-by: Xuanwo <[email protected]> --------- Signed-off-by: Xuanwo <[email protected]>
apache · Jan 28, 2023 · 3066afc · 3066afc · github-actions · Jan 28, 2023
1 parent c87bf68
commit 3066afc
Show file tree

Hide file tree

Showing 6 changed files with 125 additions and 274 deletions.
diff --git a/Cargo.toml b/Cargo.toml
@@ -71,15 +71,6 @@ name = "ops"
 harness = false
 name = "io"
 
-[[bench]]
-harness = false
-name = "path"
-
-[[bench]]
-harness = false
-name = "layers"
-required-features = ["layers-all"]
-
 [[example]]
 name = "hdfs"
 required-features = ["services-hdfs"]

diff --git a/benches/layers.rs b/benches/layers.rs
diff --git a/benches/path.rs b/benches/path.rs
diff --git a/src/raw/io/output/into_blocking_reader/from_fd.rs b/src/raw/io/output/into_blocking_reader/from_fd.rs
@@ -86,11 +86,6 @@ where
                 "invalid seek to a negative or overflowing position",
             )),
             Some(n) => {
-                // Ignore seek operation if we are already on start.
-                if self.offset == n as u64 {
-                    return Ok(self.offset - self.start);
-                }
-
                 let cur = self.inner.seek(SeekFrom::Start(n as u64))?;
 
                 self.offset = cur;

diff --git a/src/raw/io/output/into_reader/from_fd.rs b/src/raw/io/output/into_reader/from_fd.rs
@@ -91,11 +91,6 @@ where
                 "invalid seek to a negative or overflowing position",
             ))),
             Some(n) => {
-                // Ignore seek operation if we are already on start.
-                if self.offset == n as u64 {
-                    return Poll::Ready(Ok(self.offset - self.start));
-                }
-
                 let cur =
                     ready!(Pin::new(&mut self.inner).poll_seek(cx, SeekFrom::Start(n as u64)))?;