Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tracking issues of RFC-2758: Merge Append Into Write #2760

Closed
4 tasks
Tracked by #2788
Xuanwo opened this issue Aug 2, 2023 · 6 comments · Fixed by #2880
Closed
4 tasks
Tracked by #2788

Tracking issues of RFC-2758: Merge Append Into Write #2760

Xuanwo opened this issue Aug 2, 2023 · 6 comments · Fixed by #2880
Labels
help wanted Extra attention is needed

Comments

@Xuanwo
Copy link
Member

Xuanwo commented Aug 2, 2023 •
edited
Loading

RFC: #2758

Tasks

  • Add append in OpWrite
  • Add new capability write_with_append
  • Implement append (or return errors) based on append flag
  • Remove all append and appender related code
@Xuanwo Xuanwo added the help wanted Extra attention is needed label Aug 2, 2023
@suyanhanx
Copy link
Member

Will append support abort?

@Xuanwo
Copy link
Member Author

Xuanwo commented Aug 3, 2023

Will append support abort?

Yes. abort's semantic will become aborting not committed (or flushed) data.

@oowl
Copy link
Member

oowl commented Aug 3, 2023

I will take over it.

@oowl oowl self-assigned this Aug 3, 2023
@suyanhanx
Copy link
Member

I will take over it.

Hi, we could use separate issues to mark sub tasks.

@Xuanwo
Copy link
Member Author

Xuanwo commented Aug 3, 2023 •
edited
Loading

Yep, it's better to assign with sub tasks instead of the tracking issue itself. We can create new issues from task list and assign self.

In this way, our community will also have opportunity to take part in.

@Xuanwo Xuanwo mentioned this issue Aug 6, 2023
Closed
18 tasks
@Xuanwo
Copy link
Member Author

Xuanwo commented Aug 16, 2023

I'm working on this now.

@Xuanwo Xuanwo mentioned this issue Aug 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Implement RFC-2758 Merge Append Into Write apache/opendal
3 participants
@Xuanwo @suyanhanx @oowl