Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Implement RFC-2758 Merge Append Into Write #2880

Merged
merged 10 commits into from
Aug 20, 2023
Merged

feat: Implement RFC-2758 Merge Append Into Write #2880

merged 10 commits into from
Aug 20, 2023

Conversation

Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented Aug 19, 2023

Fix #2760

@Xuanwo
allow append for azblob
bf80ca7 
Signed-off-by: Xuanwo <[email protected]>
@Xuanwo
Fix test
c6dfaf5 
Signed-off-by: Xuanwo <[email protected]>
@Xuanwo Xuanwo changed the title feat: Implement RFC-2758: Merge Append Into Write feat: Implement RFC-2758 Merge Append Into Write Aug 19, 2023
@Xuanwo
Copy link
Member Author

Xuanwo commented Aug 20, 2023

cc @suyanhanx @Ji-Xinyou PTAL

@xyjixyjixyji
Copy link
Contributor

Bravo work! Other parts of the code mostly LGTM, we can leave some misc thing for future PRs.

suyanhanx
suyanhanx approved these changes Aug 20, 2023
View reviewed changes
Copy link
Member

@suyanhanx suyanhanx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@Xuanwo Xuanwo merged commit 8ea4f22 into main Aug 20, 2023
92 checks passed
@Xuanwo Xuanwo deleted the remove-append branch August 20, 2023 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xyjixyjixyji xyjixyjixyji xyjixyjixyji left review comments

@suyanhanx suyanhanx suyanhanx approved these changes

@tisonkun tisonkun Awaiting requested review from tisonkun tisonkun is a code owner

@oowl oowl Awaiting requested review from oowl

@ClSlaid ClSlaid Awaiting requested review from ClSlaid

@silver-ymz silver-ymz Awaiting requested review from silver-ymz

Assignees
No one assigned
Labels
releases-note/feat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tracking issues of RFC-2758: Merge Append Into Write
3 participants
@Xuanwo @xyjixyjixyji @suyanhanx