Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

services/azfile: Check if dir exists before create #3646

Closed
Xuanwo opened this issue Nov 22, 2023 · 2 comments · Fixed by #3652
Closed

services/azfile: Check if dir exists before create #3646

Xuanwo opened this issue Nov 22, 2023 · 2 comments · Fixed by #3652
Assignees
@ZutJoe
Labels
good first issue Good for newcomers help wanted Extra attention is needed services/azfile

Comments

@Xuanwo
Copy link
Member

Xuanwo commented Nov 22, 2023

https://github.com/apache/incubator-opendal/blob/b2b615b16f977dc3f889bc7bfe13a54106aea9b9/core/src/services/azfile/core.rs#L417-L423

For every request, we need to check if dir exists for the while path. Maybe we can check if dir exists before creating them?
@Xuanwo Xuanwo added services/azfile good first issue Good for newcomers help wanted Extra attention is needed labels Nov 22, 2023
@ZutJoe
Copy link
Contributor

ZutJoe commented Nov 22, 2023

i want to try it

@Xuanwo
Copy link
Member Author

Xuanwo commented Nov 22, 2023

i want to try it

Thanks a lot!

ZutJoe added a commit to ZutJoe/incubator-opendal that referenced this issue Nov 22, 2023
@ZutJoe
refactor(services/azfile): Check if dir exists before create (apache#…
8cc1b39 
…3646)
@ZutJoe ZutJoe mentioned this issue Nov 22, 2023
Closed
ZutJoe added a commit to ZutJoe/incubator-opendal that referenced this issue Nov 22, 2023
@ZutJoe
refactor(services/azfile): Check if dir exists before create (apache#…
534322d 
…3646)
@ZutJoe ZutJoe mentioned this issue Nov 22, 2023
Merged
Xuanwo pushed a commit that referenced this issue Nov 23, 2023
@ZutJoe
refactor(services/azfile): Check if dir exists before create (#3652)
3f868cc 
* refactor(services/azfile): Check if dir exists before create (#3646)

* perf: change the sequence of checking dir

* fix: fmt code

* refactor: fmt

* refactor: fmt
Xuanwo pushed a commit that referenced this issue Nov 23, 2023
@ZutJoe
feat: disable ftp for python and java binding (#3659)
44f06f4 
* refactor(services/azfile): Check if dir exists before create (#3646)

* perf: change the sequence of checking dir

* fix: fmt code

* refactor: fmt

* refactor: fmt

* feat: disable ftp for python and java binding

* docs: complete information

* docs: move content location
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ZutJoe ZutJoe

Labels
good first issue Good for newcomers help wanted Extra attention is needed services/azfile
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(services/azfile): Check if dir exists before create ZutJoe/incubator-opendal
2 participants
@Xuanwo @ZutJoe