Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bindings/java: Align naming style #4628

Closed
Xuanwo opened this issue May 17, 2024 · 1 comment
Closed

bindings/java: Align naming style #4628

Xuanwo opened this issue May 17, 2024 · 1 comment

Comments

@Xuanwo
Copy link
Member

Xuanwo commented May 17, 2024

#4626 is going to introduce OperatorInputStream which is a blocking based API. This design doesn't align with our existing async Operator and BlockingOperator.

Due to the existing java's BlockignQueue and similiar API, we can't call OperatorInputStream as BlockingOperatorInputStream.

After offline discussion with @tisonkun, we decided to move the naming pattern that use Operator for blocking operations and AsyncOperator for async operations.
@Xuanwo Xuanwo mentioned this issue May 17, 2024
Merged
@Xuanwo
Copy link
Member Author

Xuanwo commented May 17, 2024

Duplicated with #4629

@Xuanwo Xuanwo closed this as not planned Won't fix, can't repro, duplicate, stale May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Xuanwo