Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Java's BlockingOperator as Operator and the original async Operator as AsyncOperator #4629

Closed
Tracked by #4640
tisonkun opened this issue May 17, 2024 · 0 comments · Fixed by #4641
Closed
Tracked by #4640

Comments

@tisonkun
Copy link
Member

Although I'd like to keep the async the default, @Xuanwo has a strong feeling about naming in #4626.

After a discussion offline, we agreed to follow Java's idiom to call the async version as AsyncOperator so that OperatorInputStream is a sync version.

I have a different opinion that InputStream is always sync because the async version should be something depends on ReactiveStream tech. And calling it BlockingOperatorInputStream is redundant. But I don't have such a strong feeling on switching BlockingOperator and Operator, while @Xuanwo's prefer to keep the name "consistent" so that "OperatorInputStream" associated to the blocking version "Operator".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants