-
Notifications
You must be signed in to change notification settings - Fork 472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use std::path::Path for fs backend #1100
Conversation
The |
On windows, fs backend must specify a root-like |
Hi, in PR #1221, I make opendal's test buildable on windows. |
Nice @Xuanwo ! |
Awesome thanks! I will integrate! |
0f78239
to
223ba07
Compare
I redid the whole thing from scratch. I got all opendal's tests working (at least locally). The only thing I don't know how to solve exactly is using an empty Curious about what you think! |
LGTM! |
This PR looks nice now, please update with main branch and make our CI passed on windows platform (fs local test) |
Thanks a lot! |
I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/
Summary
As discussed in #137 this PR changes the internals of the
fs
backend to usestd::path::Path
. This enables using all the path types thatstd::path::Path
supports like Windows disk drive prefixes and network drives.This is my first contribution! Im looking forward to your feedback!