feat: Allow passing content_type to OSS presign #1252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flaneur2020
changed the title
flaneur2020
force-pushed
the
try-add-set-content-type
branch
from
7337683
to
49cff86
Compare
flaneur2020
force-pushed
the
try-add-set-content-type
branch
from
49cff86
to
e94721f
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/
Summary
Currently, there's no content-type header at all in the current presign operation. However, browsers have a limit about there's no way to NOT passing Content-Type on a
fetch()operation. Thus it's hard to do upload presigned urls in a website.This PR allows passing content-type on presign write operations:
presign_write_withmethod to Objectfixes #421