Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add dev container #1261

Merged
merged 6 commits into from
Jan 31, 2023
Merged

feat: add dev container #1261

merged 6 commits into from
Jan 31, 2023

Conversation

PsiACE
Copy link
Member

@PsiACE PsiACE commented Jan 30, 2023

Signed-off-by: Chojan Shang [email protected]

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

Close: #925

@PsiACE
Copy link
Member Author

PsiACE commented Jan 30, 2023

with packages for --all-features, jdk libssl-dev
with useful tools like mold
with out node and maturin

@PsiACE PsiACE requested a review from Xuanwo January 30, 2023 20:59
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing! The container works, but it takes so long to build which I think is not good for a new contributor to play with. Maybe we can remove parts that are not required to have?


I have to wait here for 20 minutes.

image

.devcontainer/Dockerfile Outdated Show resolved Hide resolved
.devcontainer/Dockerfile Outdated Show resolved Hide resolved
.devcontainer/Dockerfile Outdated Show resolved Hide resolved
@Xuanwo
Copy link
Member

Xuanwo commented Jan 31, 2023

The init hang on here:

image

And running cargo build will meet:

builder@codespaces-c7d3d1:/workspaces/opendal$ cargo build
    Updating crates.io index
warning: spurious network error (2 tries remaining): failed to create temporary file '/opt/rust/cargo/registry/index/github.com-1ecc6299db9ec823/.git/objects/pack/pack_git2_c95b667278ef086b': Permission denied; class=Os (2)
warning: spurious network error (1 tries remaining): failed to create temporary file '/opt/rust/cargo/registry/index/github.com-1ecc6299db9ec823/.git/objects/pack/pack_git2_d6c3737348f26a64': Permission denied; class=Os (2)
error: failed to get `anyhow` as a dependency of package `opendal v0.25.2 (/workspaces/opendal)`

Caused by:
  failed to load source for dependency `anyhow`

Caused by:
  Unable to update registry `crates-io`

Caused by:
  failed to fetch `https://github.com/rust-lang/crates.io-index`

Caused by:
  failed to create temporary file '/opt/rust/cargo/registry/index/github.com-1ecc6299db9ec823/.git/objects/pack/pack_git2_236d4573de3cb376': Permission denied; class=Os (2)
builder@codespaces-c7d3d1:/workspaces/opendal$ ^C

@Xuanwo
Copy link
Member

Xuanwo commented Jan 31, 2023

postCreateCommand is running inside container, maybe it's too late?

@PsiACE
Copy link
Member Author

PsiACE commented Jan 31, 2023

I did not encounter hangs and other strange errors, maybe you can try it again

Signed-off-by: Chojan Shang <[email protected]>
Signed-off-by: Chojan Shang <[email protected]>
@Xuanwo Xuanwo merged commit 9310cde into apache:main Jan 31, 2023
@PsiACE PsiACE deleted the dev-vscode branch January 31, 2023 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add DevContainer config to make it easier in code space
2 participants