Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Sled support #1305

Merged
merged 4 commits into from
Feb 9, 2023
Merged

Conversation

jkleinknox
Copy link
Contributor

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

Adds read/write/blocking support for Sled.

@jkleinknox jkleinknox changed the title Added Sled support for Read/Write/Blocking Added Sled support Feb 8, 2023
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM

Cargo.toml Outdated Show resolved Hide resolved
@Xuanwo Xuanwo changed the title Added Sled support feat: Add Sled support Feb 9, 2023
@Xuanwo
Copy link
Member

Xuanwo commented Feb 9, 2023

Please merge or rebase with main, I am ready to merge it~.

By the way, I'm working on #353 right now, we can add list/scan support for Sled after this issue is fixed. I hope this will be done tomorrow.

@Xuanwo Xuanwo merged commit fb4ac35 into apache:main Feb 9, 2023
@jkleinknox jkleinknox mentioned this pull request Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants