-
Notifications
You must be signed in to change notification settings - Fork 472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(webdav): add list and improve create #1330
Conversation
c0bfb0e
to
31321b1
Compare
Posting this WIP PR because I'm pretty new and a bit worried that I will go on the wrong directory. Please feel free to point out problems. Thanks in advance! |
Not a problem anymore |
Still seeing this error:
Not sure where to fix? |
c250317
to
4cd1358
Compare
@Xuanwo I have to go to sleep today. Will (probably) refine this PR tomorrow. I noticed some logic error of my implementation at this moment. Very appreciate your review! |
Wish you a beautiful night ❤️ ! Thank you so much! |
Hi @Xuanwo, I spent most of today to debug this issue but haven't found a clue. May I have some hints on this? Some behavior tests always fail. I'm not sure about its reason after I managed to attaching debugger to tests.
Environment variables:
|
Please always return Ok for dir. Take http service or s3 service as an example. Sorry for the confusion, I will add it in docs. |
Thanks! This is super quick reply! |
9baa530
to
a86f1a8
Compare
# Conflicts: # src/services/webdav/backend.rs
list
and create
(with MKCOL)
list
and create
(with MKCOL)list
and create
(with MKCOL)
list
and create
(with MKCOL)list
and improve create
(with MKCOL)
list
and improve create
(with MKCOL)
Thank you so much for the effort you put into this feature! It's a lot more complex than I expected, but you've mastered them all. Good job! |
I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/
Summary
list
create
MKCOL
http method support for creating directories