Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: improve the python binding implementation #1517

Merged
merged 7 commits into from
Mar 9, 2023
Merged

refactor: improve the python binding implementation #1517

merged 7 commits into from
Mar 9, 2023

Conversation

frostming
Copy link
Contributor

Signed-off-by: Frost Ming [email protected]

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

Summary about this PR

  1. Expose a custom error subclassing PyException, instead of PyBaseException
  2. Make read() return Python bytes
  3. Change the method of Metadata to getter
  4. Conver the test script into basic pytest cases

Xuanwo
Xuanwo reviewed Mar 8, 2023
View reviewed changes
bindings/python/src/lib.rs Outdated Show resolved Hide resolved
Xuanwo
Xuanwo approved these changes Mar 9, 2023
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks a lot!

@Xuanwo Xuanwo changed the title fix: improve the python binding implementation refactor: improve the python binding implementation Mar 9, 2023
@Xuanwo Xuanwo merged commit 212b424 into apache:main Mar 9, 2023
@frostming frostming deleted the bindings/python-pytest branch March 10, 2023 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@messense messense messense left review comments

@Xuanwo Xuanwo Xuanwo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@frostming @messense @Xuanwo