Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(bindings/nodejs): Remove scheme from bindings #1552

Merged
merged 2 commits into from
Mar 10, 2023
Merged

Conversation

Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented Mar 10, 2023

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

refactor(bindings/nodejs): Remove scheme from bindings

@Xuanwo
Copy link
Member Author

Xuanwo commented Mar 10, 2023

cc @suyanhanx for review

Signed-off-by: Xuanwo <[email protected]>
Copy link
Member

@suyanhanx suyanhanx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@Xuanwo Xuanwo merged commit c0ed0d3 into main Mar 10, 2023
@Xuanwo Xuanwo deleted the remove-scheme branch March 10, 2023 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants