Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(bindings/nodejs): fix missing files to publish #1569

Merged
merged 1 commit into from
Mar 12, 2023

Conversation

suyanhanx
Copy link
Member

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

add some props to readme

And we should generate files to publish

Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM

bindings/nodejs/npm/darwin-x64/README.md Show resolved Hide resolved
@Xuanwo Xuanwo merged commit 53100e7 into apache:main Mar 12, 2023
@suyanhanx suyanhanx deleted the fix-readme branch March 12, 2023 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants