Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(bindings/nodejs): Publish sub-package name #1704

Merged
merged 5 commits into from
Mar 20, 2023
Merged

fix(bindings/nodejs): Publish sub-package name #1704

merged 5 commits into from
Mar 20, 2023

Conversation

suyanhanx
Copy link
Member

@suyanhanx suyanhanx commented Mar 20, 2023 •
edited
Loading

fix #1695

@suyanhanx suyanhanx force-pushed the fix-publish branch 2 times, most recently from 6b3f536 to 81d40bf Compare March 20, 2023 12:20
Xuanwo
Xuanwo reviewed Mar 20, 2023
View reviewed changes
bindings/nodejs/generated.js Show resolved Hide resolved
bindings/nodejs/package.json Show resolved Hide resolved
Xuanwo
Xuanwo approved these changes Mar 20, 2023
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks a lot!

@suyanhanx
Copy link
Member Author

🤣

@Xuanwo Xuanwo merged commit 4d7cac2 into apache:main Mar 20, 2023
@suyanhanx suyanhanx deleted the fix-publish branch March 20, 2023 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xuanwo Xuanwo Xuanwo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bindings/nodejs: 'generated.js' file is missing and dependencies are incorrect
2 participants
@suyanhanx @Xuanwo