Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(bindings/ruby): Setup the integrate with magnus #1712

Merged
merged 11 commits into from
Mar 21, 2023
Merged

feat(bindings/ruby): Setup the integrate with magnus #1712

merged 11 commits into from
Mar 21, 2023

Conversation

PsiACE
Copy link
Member

@PsiACE PsiACE commented Mar 21, 2023

draft: try to integrate with magnus
note: bump rocksdb to 0.18.0 , librocksdb-sys to 0.6.1

Xuanwo
Xuanwo reviewed Mar 21, 2023
View reviewed changes
core/Cargo.toml Outdated Show resolved Hide resolved
Xuanwo
Xuanwo reviewed Mar 21, 2023
View reviewed changes
Cargo.toml Outdated Show resolved Hide resolved
@PsiACE PsiACE marked this pull request as draft March 21, 2023 10:00
@PsiACE PsiACE marked this pull request as ready for review March 21, 2023 10:22
@Xuanwo
Copy link
Member

Xuanwo commented Mar 21, 2023 •
edited
Loading

By the way, could you explain a bit more why we chose Magnus instead of Rutie?

@PsiACE
Copy link
Member Author

PsiACE commented Mar 21, 2023

By the way, could you explain a bit more why we chose Magnus instead of Rutie?

Actually, I initially tried Rutie and successfully ran the basic examples. However, I ultimately chose Magnus for the following reasons:

  1. It relies less on macros and is easier to debug;
  2. There is no need to configure a target directory, as I am not sure how to better make Rutie work with Cargo workspace;
  3. Magnus appears to be actively maintained.

@PsiACE
feat: init ruby gem
acd566b 
Signed-off-by: Chojan Shang <[email protected]>
@PsiACE
feat: init cargo lib
23d41c2 
Signed-off-by: Chojan Shang <[email protected]>
@PsiACE
feat(bindings/ruby): try to work with magnus
291d07f 
Signed-off-by: Chojan Shang <[email protected]>
@PsiACE
fix(bindings/ruby): work with magnus
b8c6000 
Signed-off-by: Chojan Shang <[email protected]>
@PsiACE
feat(bindings/ruby): hello opendal
7ed8d7d 
Signed-off-by: Chojan Shang <[email protected]>
@PsiACE
chore(bindings/ruby): add license header
ec58e05 
Signed-off-by: Chojan Shang <[email protected]>
@PsiACE
docs(bindings/ruby): polish readme
d9e887b 
Signed-off-by: Chojan Shang <[email protected]>
@PsiACE
chore: pin rocksdb
9bdf2bb 
Signed-off-by: Chojan Shang <[email protected]>
@PsiACE
refactor: config ext_dir to keep style
5f8d86d 
Signed-off-by: Chojan Shang <[email protected]>
@PsiACE
chore: minor fix
9de2b5f 
Signed-off-by: Chojan Shang <[email protected]>
Xuanwo
Xuanwo approved these changes Mar 21, 2023
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's rock!

@PsiACE PsiACE merged commit f56aa10 into apache:main Mar 21, 2023
@PsiACE PsiACE deleted the ruby-starter branch March 21, 2023 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xuanwo Xuanwo Xuanwo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PsiACE @Xuanwo