Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: improve NotADirectory error message with ending slash #1756

Merged
merged 1 commit into from
Mar 24, 2023
Merged

chore: improve NotADirectory error message with ending slash #1756

merged 1 commit into from
Mar 24, 2023

Conversation

zwpaper
Copy link
Contributor

@zwpaper zwpaper commented Mar 24, 2023

fix #1732

Xuanwo
Xuanwo approved these changes Mar 24, 2023
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@Xuanwo Xuanwo merged commit 8325b08 into apache:main Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xuanwo Xuanwo Xuanwo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Should return error with more detail for validate_path
2 participants
@zwpaper @Xuanwo