Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(bindings/nodejs): init benchmark #1798

Merged
merged 5 commits into from
Mar 30, 2023
Merged

chore(bindings/nodejs): init benchmark #1798

merged 5 commits into from
Mar 30, 2023

Conversation

promer94
Copy link
Contributor

@promer94 promer94 commented Mar 29, 2023 •
edited by suyanhanx
Loading

suyanhanx
suyanhanx reviewed Mar 30, 2023
View reviewed changes
bindings/nodejs/package.json Show resolved Hide resolved
bindings/nodejs/generated.js Show resolved Hide resolved
bindings/nodejs/examples/presign.js Outdated Show resolved Hide resolved
bindings/nodejs/examples/presign.js Outdated Show resolved Hide resolved
Xuanwo
Xuanwo reviewed Mar 30, 2023
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I left some comments here.

bindings/nodejs/package.json Outdated Show resolved Hide resolved
bindings/nodejs/examples/presign.js Outdated Show resolved Hide resolved
bindings/nodejs/benchmark/index.js Outdated Show resolved Hide resolved
@Xuanwo
Copy link
Member

Xuanwo commented Mar 30, 2023

The example file has been removed from #1799. As a result, this PR can now focus on benchmarking 🚀

@suyanhanx suyanhanx changed the title chore(bindings/nodejs): update presign example and init benchmark chore(bindings/nodejs): init benchmark Mar 30, 2023
Xuanwo
Xuanwo approved these changes Mar 30, 2023
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, mostly LGTM! Thanks a lot!

bindings/nodejs/generated.js Outdated Show resolved Hide resolved
suyanhanx
suyanhanx approved these changes Mar 30, 2023
View reviewed changes
Copy link
Member

@suyanhanx suyanhanx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks

@Xuanwo Xuanwo merged commit 04456bf into apache:main Mar 30, 2023
@promer94 promer94 deleted the presign-example branch March 30, 2023 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xuanwo Xuanwo Xuanwo approved these changes

@suyanhanx suyanhanx suyanhanx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@promer94 @Xuanwo @suyanhanx