Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add override_cache_control #1804

Merged
merged 2 commits into from
Mar 30, 2023
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 24 additions & 7 deletions core/src/services/s3/backend.rs
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,7 @@ mod constants {
pub const X_AMZ_BUCKET_REGION: &str = "x-amz-bucket-region";

pub const RESPONSE_CONTENT_DISPOSITION: &str = "response-content-disposition";
pub const RESPONSE_CACHE_CONTROL: &str = "response-cache-control";
}

/// Aws S3 and compatible services (including minio, digitalocean space and so on) support
Expand Down Expand Up @@ -1241,9 +1242,12 @@ impl Accessor for S3Backend {
// We will not send this request out, just for signing.
let mut req = match args.operation() {
PresignOperation::Stat(_) => self.s3_head_object_request(path)?,
PresignOperation::Read(v) => {
self.s3_get_object_request(path, v.range(), v.override_content_disposition())?
}
PresignOperation::Read(v) => self.s3_get_object_request(
path,
v.range(),
v.override_content_disposition(),
v.override_cache_control(),
)?,
PresignOperation::Write(_) => {
self.s3_put_object_request(path, None, None, None, AsyncBody::Empty)?
}
Expand Down Expand Up @@ -1334,18 +1338,31 @@ impl S3Backend {
path: &str,
range: BytesRange,
override_content_disposition: Option<&str>,
override_cache_control: Option<&str>,
) -> Result<Request<AsyncBody>> {
let p = build_abs_path(&self.root, path);

// Construct headers to add to the request
let mut url = format!("{}/{}", self.endpoint, percent_encode_path(&p));

// Add query arguments to the URL based on response overrides
let mut query_args = Vec::new();
if let Some(override_content_disposition) = override_content_disposition {
url.push_str(&format!(
"?{}={}",
query_args.push(format!(
"{}={}",
constants::RESPONSE_CONTENT_DISPOSITION,
percent_encode_path(override_content_disposition)
));
))
}
if let Some(override_cache_control) = override_cache_control {
query_args.push(format!(
"{}={}",
constants::RESPONSE_CACHE_CONTROL,
percent_encode_path(override_cache_control)
))
}
if !query_args.is_empty() {
url.push_str(&format!("?{}", query_args.join("&")));
}

let mut req = Request::get(&url);
Expand All @@ -1370,7 +1387,7 @@ impl S3Backend {
path: &str,
range: BytesRange,
) -> Result<Response<IncomingAsyncBody>> {
let mut req = self.s3_get_object_request(path, range, None)?;
let mut req = self.s3_get_object_request(path, range, None, None)?;

self.signer.sign(&mut req).map_err(new_request_sign_error)?;

Expand Down
12 changes: 12 additions & 0 deletions core/src/types/ops.rs
Original file line number Diff line number Diff line change
Expand Up @@ -231,6 +231,7 @@ impl BatchOperations {
pub struct OpRead {
br: BytesRange,
override_content_disposition: Option<String>,
override_cache_control: Option<String>,
}

impl OpRead {
Expand Down Expand Up @@ -264,6 +265,17 @@ impl OpRead {
pub fn override_content_disposition(&self) -> Option<&str> {
self.override_content_disposition.as_deref()
}

/// Sets the cache-control header that should be send back by the remote read operation.
pub fn with_override_cache_control(mut self, cache_control: impl Into<String>) -> Self {
Xuanwo marked this conversation as resolved.
Show resolved Hide resolved
self.override_cache_control = Some(cache_control.into());
self
}

/// Returns the cache-control header that should be send back by the remote read operation.
pub fn override_cache_control(&self) -> Option<&str> {
self.override_cache_control.as_deref()
}
}

/// Args for `stat` operation.
Expand Down