Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(services/redis): Add dragonfly test #1808

Merged
merged 2 commits into from
Mar 31, 2023
Merged

ci(services/redis): Add dragonfly test #1808

merged 2 commits into from
Mar 31, 2023

Conversation

teckick
Copy link
Contributor

@teckick teckick commented Mar 30, 2023 •
edited
Loading

solve #1800

@teckick teckick changed the title add dragonfly redis test add dragonfly test Mar 30, 2023
@teckick
Copy link
Contributor Author

teckick commented Mar 30, 2023

The memcached test failed, since github action services does not support passing command line args.

Xuanwo
Xuanwo reviewed Mar 31, 2023
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much! Most of it looks good to me, but I do have a few comments.

.github/workflows/service_test_dragonfly.yml Outdated Show resolved Hide resolved
.github/workflows/service_test_dragonfly.yml Outdated Show resolved Hide resolved
@Xuanwo Xuanwo changed the title add dragonfly test ci(services/redis): Add dragonfly test Mar 31, 2023
Xuanwo
Xuanwo approved these changes Mar 31, 2023
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@Xuanwo Xuanwo merged commit 7f68838 into apache:main Mar 31, 2023
@Xuanwo Xuanwo mentioned this pull request Mar 31, 2023
Closed
@teckick teckick deleted the test-dragonfly branch March 31, 2023 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xuanwo Xuanwo Xuanwo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@teckick @Xuanwo