feat: Retry when some of batch operations are failing #1840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also added a test for retry on batch operation. This implementation is not so elegant as far as I'm considering. Batch operation could possibly be retried even when result is `Ok`. So I had to wrap it in a `Result<(), Result<RpBatch>>` type. And the `errors` method on `BatchedResult` requires dynamic dispatching.
nasen23
requested review from
Xuanwo,
PsiACE,
ClSlaid and
sundy-li
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also added a test for retry on batch operation.
This implementation works as expected but is not so elegant as far as I'm considering. Batch operation could possibly be retried even when result is
Ok. So I had to wrap it in aResult<(), Result<RpBatch>>type. And theerrorsmethod onBatchedResultsrequires dynamic dispatching.Regarding the issue mentioned above, would you be able to suggest any better solutions or provide further guidance?