New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(bindings/c): fix c bindings makefile #1849

Merged

Xuanwo merged 1 commit into apache:main from xyjixyjixyji:cbindings

Apr 4, 2023

Contributor

xyjixyjixyji commented Apr 4, 2023

Fixed the OBJDIR creation and library link flag

The library created by cbindgen is called libopendal_c instead of libopendal, so the original -lopendal does not work
At least on my machine, the OBJDIR is not created by the Makefile, so this change make sure that the directory is created.


          feat(bindings/c): fix c bindings makefile

18c08c6

Fixed the OBJDIR creation and library link flag

Signed-off-by: Ji-Xinyou <[email protected]>

xyjixyjixyji requested review from Xuanwo, PsiACE, ClSlaid and sundy-li as code owners

April 4, 2023 03:34

Xuanwo approved these changes

View reviewed changes

Member

Xuanwo left a comment

Thanks!

Xuanwo merged commit 834957c into apache:main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet