Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

binding/c: build: add phony to makefile, and some improve #1850

Merged
merged 1 commit into from
Apr 4, 2023
Merged

binding/c: build: add phony to makefile, and some improve #1850

merged 1 commit into from
Apr 4, 2023

Conversation

zwpaper
Copy link
Contributor

@zwpaper zwpaper commented Apr 4, 2023

  1. make build will do nothing if build dir existed without .PHONY
  2. only make build should create the build dir, so keep it under make build
  3. we should be careful to rf -rf, so added a quote and ./

PsiACE
PsiACE approved these changes Apr 4, 2023
View reviewed changes
Copy link
Member

@PsiACE PsiACE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks

@PsiACE PsiACE merged commit ff10d37 into apache:main Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PsiACE PsiACE PsiACE approved these changes

@Xuanwo Xuanwo Awaiting requested review from Xuanwo

@ClSlaid ClSlaid Awaiting requested review from ClSlaid

@sundy-li sundy-li Awaiting requested review from sundy-li

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zwpaper @PsiACE