Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Use reqwest blocking client instead of ureq #1853

Merged
merged 4 commits into from
Apr 4, 2023

Conversation

Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented Apr 4, 2023

This PR will remove the logic of region detect. This will be replaced by region provided by reqsign.

We keep ureq here to make our CI pass. It will be remove after we migrated to the new reqsign

@Xuanwo Xuanwo marked this pull request as draft April 4, 2023 15:49
@Xuanwo Xuanwo marked this pull request as ready for review April 4, 2023 15:50
Signed-off-by: Xuanwo <[email protected]>
Copy link
Member

@suyanhanx suyanhanx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Xuanwo Xuanwo merged commit ee74e18 into main Apr 4, 2023
@Xuanwo Xuanwo deleted the integrate-with-new-reqsign branch April 4, 2023 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants