Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(services/oss): add oss cache-control header support #1986

Merged
merged 1 commit into from
Apr 14, 2023

Conversation

ahonn
Copy link
Contributor

@ahonn ahonn commented Apr 14, 2023

No description provided.

Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Mostly LGTM.

The only thing left is to pass all our checks.

Running cargo fmt to make sure code has been formatted.

@Xuanwo
Copy link
Member

Xuanwo commented Apr 14, 2023

Test failed for

error: this function has too many arguments (8/7)
   --> core/src/services/oss/core.rs:110:5
    |
110 | /     pub fn oss_put_object_request(
111 | |         &self,
112 | |         path: &str,
113 | |         size: Option<usize>,
...   |
118 | |         is_presign: bool,
119 | |     ) -> Result<Request<AsyncBody>> {
    | |___________________________________^
    |
    = note: `-D clippy::too-many-arguments` implied by `-D warnings`
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments

Please ignore this error by adding a #[allow(clippy::too_many_arguments)]. We will refactor this part later.

@ahonn
Copy link
Contributor Author

ahonn commented Apr 14, 2023

Test failed for

error: this function has too many arguments (8/7)
   --> core/src/services/oss/core.rs:110:5
    |
110 | /     pub fn oss_put_object_request(
111 | |         &self,
112 | |         path: &str,
113 | |         size: Option<usize>,
...   |
118 | |         is_presign: bool,
119 | |     ) -> Result<Request<AsyncBody>> {
    | |___________________________________^
    |
    = note: `-D clippy::too-many-arguments` implied by `-D warnings`
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments

Please ignore this error by adding a #[allow(clippy::too_many_arguments)]. We will refactor this part later.

Sure, error ignored.
And maybe we need a struct like OssHeaders to handle that.

Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@Xuanwo Xuanwo merged commit 989ddb1 into apache:main Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants