Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(services/gcs): Allow setting default storage_class #1996

Merged
merged 3 commits into from
Apr 14, 2023
Merged

feat(services/gcs): Allow setting default storage_class #1996

merged 3 commits into from
Apr 14, 2023

Conversation

silver-ymz
Copy link
Member

@silver-ymz silver-ymz commented Apr 14, 2023 •
edited by Xuanwo
Loading

Fix #1983

Xuanwo
Xuanwo reviewed Apr 14, 2023
View reviewed changes
core/src/services/gcs/backend.rs Outdated Show resolved Hide resolved
core/src/services/gcs/backend.rs Show resolved Hide resolved
core/src/services/gcs/core.rs Outdated Show resolved Hide resolved
core/src/services/gcs/core.rs Outdated Show resolved Hide resolved
core/src/services/gcs/core.rs Outdated Show resolved Hide resolved
Xuanwo
Xuanwo reviewed Apr 14, 2023
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM now!

core/src/services/gcs/core.rs Outdated Show resolved Hide resolved
Xuanwo
Xuanwo approved these changes Apr 14, 2023
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Xuanwo Xuanwo merged commit ec9edd1 into apache:main Apr 14, 2023
@silver-ymz silver-ymz deleted the gcs_storage_class branch April 14, 2023 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xuanwo Xuanwo Xuanwo approved these changes

@PsiACE PsiACE Awaiting requested review from PsiACE

@ClSlaid ClSlaid Awaiting requested review from ClSlaid

@sundy-li sundy-li Awaiting requested review from sundy-li

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow setting default storage_class for gcs
2 participants
@silver-ymz @Xuanwo