Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: MadsimLayer should be able to built without cfg #2059

Merged
merged 10 commits into from
Apr 21, 2023
Merged

fix: MadsimLayer should be able to built without cfg #2059

merged 10 commits into from
Apr 21, 2023

Conversation

Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented Apr 21, 2023

Fix #2058

@Xuanwo Xuanwo marked this pull request as ready for review April 21, 2023 13:42
@Xuanwo
Fix typo
e8738af 
Signed-off-by: Xuanwo <[email protected]>
suyanhanx
suyanhanx approved these changes Apr 21, 2023
View reviewed changes
Copy link
Member

@suyanhanx suyanhanx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@Xuanwo Xuanwo merged commit 80ab419 into main Apr 21, 2023
@Xuanwo Xuanwo deleted the fix-madsim branch April 21, 2023 14:35
@Xuanwo Xuanwo mentioned this pull request Apr 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suyanhanx suyanhanx suyanhanx approved these changes

@PsiACE PsiACE Awaiting requested review from PsiACE

@ClSlaid ClSlaid Awaiting requested review from ClSlaid

@sundy-li sundy-li Awaiting requested review from sundy-li

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: madsim layer is borken for it's cfg requirement
2 participants
@Xuanwo @suyanhanx