Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): test for read_with_override_content_composition #2067

Merged
merged 1 commit into from
Apr 22, 2023
Merged

feat(core): test for read_with_override_content_composition #2067

merged 1 commit into from
Apr 22, 2023

Conversation

suyanhanx
Copy link
Member

@suyanhanx suyanhanx commented Apr 22, 2023 •
edited
Loading

It's an experimental draft of read_with_some_headers. part of #2060

Seems that we don't have a way to check the response headers now.

cc @Xuanwo

Xuanwo
Xuanwo reviewed Apr 22, 2023
View reviewed changes
core/src/types/operator/metadata.rs Outdated Show resolved Hide resolved
core/tests/behavior/write.rs Outdated Show resolved Hide resolved
core/tests/behavior/write.rs Outdated Show resolved Hide resolved
@suyanhanx suyanhanx force-pushed the test-for-read-with-override-content-composition branch 2 times, most recently from 886e86a to 466e390 Compare April 22, 2023 11:16
@suyanhanx
Copy link
Member Author

Bad news. azblob has not implement presign. I set s3 for test.

PTAL. @Xuanwo

https://github.com/apache/incubator-opendal/actions/runs/4772535050/jobs/8485097115?pr=2067

Xuanwo
Xuanwo reviewed Apr 22, 2023
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM.

core/src/services/s3/backend.rs Outdated Show resolved Hide resolved
@suyanhanx
Copy link
Member Author

Mostly LGTM.

Well, there are some errors that happened in s3_with_sse_c. Could you help me to take a look later?

@Xuanwo
Copy link
Member

Xuanwo commented Apr 22, 2023

All returned headers should be added in request. Please take a look over presign:

https://github.com/apache/incubator-opendal/blob/main/core/tests/behavior/presign.rs#L161-L163

@suyanhanx suyanhanx force-pushed the test-for-read-with-override-content-composition branch from 3a1df36 to 9af351d Compare April 22, 2023 13:11
@suyanhanx
Copy link
Member Author

suyanhanx commented Apr 22, 2023 •
edited
Loading

Is there any process for supporting presign for azblob or other cloud storage services?

@suyanhanx suyanhanx marked this pull request as ready for review April 22, 2023 13:21
@Xuanwo
Copy link
Member

Xuanwo commented Apr 22, 2023

Is there any process for supporting presign for azblob or other cloud storage services?

Nice catch.

azblob and gcs are ready for implementing presign, just need some work at opendal side. Other services may need some extra work at reqsign side.

Are you willing to start a tracking issue with the current states for presign support?

@suyanhanx
Copy link
Member Author

suyanhanx commented Apr 22, 2023 •
edited
Loading

Are you willing to start a tracking issue with the current states for presign support?

Will open.

Xuanwo
Xuanwo approved these changes Apr 22, 2023
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@Xuanwo Xuanwo merged commit 55903bc into main Apr 22, 2023
@Xuanwo Xuanwo deleted the test-for-read-with-override-content-composition branch April 22, 2023 13:22
@suyanhanx suyanhanx mentioned this pull request Apr 22, 2023
Closed
4 tasks
@Xuanwo Xuanwo mentioned this pull request Apr 23, 2023
Merged
@suyanhanx suyanhanx mentioned this pull request Apr 23, 2023
Closed
31 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xuanwo Xuanwo Xuanwo approved these changes

@PsiACE PsiACE Awaiting requested review from PsiACE

@ClSlaid ClSlaid Awaiting requested review from ClSlaid

@sundy-li sundy-li Awaiting requested review from sundy-li

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@suyanhanx @Xuanwo