Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement Timeout Layer #2395

Merged
merged 6 commits into from
Jun 1, 2023
Merged

feat: Implement Timeout Layer #2395

merged 6 commits into from
Jun 1, 2023

Conversation

Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented Jun 1, 2023

This PR will add timeout layer for OpenDAL so users can avoid waiting for hang operations.

Signed-off-by: Xuanwo <[email protected]>
Signed-off-by: Xuanwo <[email protected]>
Copy link
Member

@suyanhanx suyanhanx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

core/src/layers/timeout.rs Outdated Show resolved Hide resolved
core/src/layers/timeout.rs Outdated Show resolved Hide resolved
core/src/layers/timeout.rs Outdated Show resolved Hide resolved
@Xuanwo Xuanwo merged commit d291356 into main Jun 1, 2023
@Xuanwo Xuanwo deleted the timeout-layer' branch June 1, 2023 10:25
@suyanhanx
Copy link
Member

suyanhanx commented Jun 1, 2023

You may need to specify in the documentation that the order in which the layer is configured affects the timing and that it, the timeout layer, should be configured first.
We can indicate in the documentation how to configure the layers appropriately.

@Xuanwo Xuanwo mentioned this pull request Jun 2, 2023
@suyanhanx suyanhanx mentioned this pull request Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants