-
Notifications
You must be signed in to change notification settings - Fork 466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(services/oss): Fix oss batch max operations #2414
Conversation
Hi, Thanks for the PR! But OSS doesn't need this setting. Maybe you can contact with @manulpatel at PR #2354 to see if you can continue his work? |
Since S3 has different implementations such as AWS S3, R2, etc., we require a configuration value for batch max operations. However, OSS only has one implementation which results in a stable batch max operation. |
sorry, i saw the issue #2228 which says s3, oss, a zblob need this setting so i did this, should i close this pr now? |
yes, i read the doc of oss, and don’t find this configuration 😥 |
Your understanding is correct. I overlooked some context regarding this issue, and now I realize that this PR is necessary. Please accept my apologies for the mistake! |
Hi, this PR is required. Let's get it merged! |
my pleasure, i will try my best |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
related issue #2228
This pr add new batch_max_operations config for oss service and use default value (1000 )if not set.